Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post on hardening the Collector #4759

Merged
merged 8 commits into from
Jul 2, 2024
Merged

Add blog post on hardening the Collector #4759

merged 8 commits into from
Jul 2, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jun 27, 2024

Adds new blog post in relation to open-telemetry/opentelemetry-collector/pull/10352 and open-telemetry/opentelemetry-collector-contrib/pull/33658.

Docs PR Checklist

  • This PR is for a documentation page whose authoritative copy is in the
    opentelemetry.io repository.

@github-actions github-actions bot added the blog label Jun 27, 2024
@mx-psi mx-psi force-pushed the mx-psi/hardening-the-collector branch from 3140eaa to 41f057b Compare June 27, 2024 13:42
@mx-psi mx-psi force-pushed the mx-psi/hardening-the-collector branch from 41f057b to 839bfaf Compare June 27, 2024 13:44
@svrnm
Copy link
Member

svrnm commented Jun 27, 2024

@mx-psi can you create an issue for this (you can keep the PR in draft) following these updated guidelines: https://opentelemetry.io/docs/contributing/blog/#before-submitting-a-blog-post ?

Thanks!

@mx-psi mx-psi mentioned this pull request Jun 27, 2024
Closed
@mx-psi
Copy link
Member Author

mx-psi commented Jun 27, 2024

@mx-psi can you create an issue for this (you can keep the PR in draft) following these updated guidelines: opentelemetry.io/docs/contributing/blog/#before-submitting-a-blog-post ?

Thanks!

@svrnm Sure! See #4760

@mx-psi mx-psi marked this pull request as ready for review June 27, 2024 13:59
@mx-psi mx-psi requested a review from a team June 27, 2024 13:59
@mx-psi
Copy link
Member Author

mx-psi commented Jun 27, 2024

@svrnm if you don't mind helping here, since the publishing date is set to July 2nd I can't preview the contents. Any suggestions here? Maybe I can change the date temporarily to help people review this?

@mx-psi @svrnm
Update content/en/blog/2024/hardening-the-collector-one.md
729082f 
Co-authored-by: Severin Neumann <neumanns@cisco.com>
theletterf
theletterf approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Can you perhaps end with a note on what to expect in Episode 2?

content/en/blog/2024/hardening-the-collector-one.md Outdated Show resolved Hide resolved
content/en/blog/2024/hardening-the-collector-one.md Outdated Show resolved Hide resolved
content/en/blog/2024/hardening-the-collector-one.md Outdated Show resolved Hide resolved
content/en/blog/2024/hardening-the-collector-one.md Outdated Show resolved Hide resolved
mx-psi and others added 2 commits June 27, 2024 16:32
@mx-psi @theletterf
Apply suggestions from code review
ee495d2 
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
@mx-psi
Add link to changelog
0c360aa
@mx-psi mx-psi force-pushed the mx-psi/hardening-the-collector branch from 888fddb to a33972c Compare June 27, 2024 15:02
@mx-psi mx-psi requested a review from svrnm June 27, 2024 15:11
@mx-psi mx-psi requested a review from TylerHelmuth June 27, 2024 15:38
svrnm
svrnm requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this until July 2nd when we want to merge it

@mx-psi let me know if you want to have it published earlier (e.g. today) then I will unblock it and merge it

content/en/blog/2024/hardening-the-collector-one.md Show resolved Hide resolved
@mx-psi
Copy link
Member Author

mx-psi commented Jun 28, 2024

Thanks @svrnm! I would like to merge it once we have v0.104.0 ready, which would be Monday/Tuesday next week. I will let you know if it happens at a different date

@TylerHelmuth
Copy link
Member

@open-telemetry/docs-maintainers the release is complete and this is ready to be merged.

@theletterf theletterf merged commit 5bdb728 into open-telemetry:main Jul 2, 2024
16 checks passed
@theletterf
Copy link
Member

Merged. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm requested changes

@jpkrohling jpkrohling jpkrohling approved these changes

@theletterf theletterf theletterf approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
blog sig:collector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mx-psi @svrnm @TylerHelmuth @theletterf @jpkrohling